#4667: [with patch, needs work] quadratic twists for p-adic L-functions
-------------------------------------------------+--------------------------
Reporter: wuthrich | Owner: was
Type: enhancement | Status: new
Priority: minor | Milestone: sage-3.4.1
Component: number theory | Resolution:
Keywords: padic l-functions, quadratic twists |
-------------------------------------------------+--------------------------
Changes (by GeorgSWeber):
* summary: [with patch, needs review] quadratic twists for p-adic
L-functions => [with patch, needs work]
quadratic twists for p-adic L-functions
Comment:
Needs work, but only minor issues:
{{{
applying ../../../patches/twisted_padic_lseries.patch
patching file sage/schemes/elliptic_curves/ell_rational_field.py
Hunk #5 FAILED at 4640
1 out of 5 hunks FAILED -- saving rejects to file
sage/schemes/elliptic_curves/ell_rational_field.py.rej
abort: patch failed to apply
}}}
That one hunk is only an empty line replacing an empty line (?!?), so
could be ignored (and wouldn't prevent a positive review from my side).
But there's real work also, some doctest failures:
{{{
sage -t -long "local/lib/python/site-
packages/sage/schemes/elliptic_curves/padic_lseries.py"
**********************************************************************
File "/Users/georgweber/Public/sage/sage-3.2.3/local/lib/python/site-
packages/sage/schemes/elliptic_curves/padic_lseries.py", line 644:
sage: E.quadratic_twist(-19).label()
Exception raised:
Traceback (most recent call last):
File
"/Users/georgweber/Public/sage/sage-3.2.3/local/bin/ncadoctest.py", line
1231, in run_one_test
self.run_one_example(test, example, filename, compileflags)
File
"/Users/georgweber/Public/sage/sage-3.2.3/local/bin/sagedoctest.py", line
38, in run_one_example
OrigDocTestRunner.run_one_example(self, test, example, filename,
compileflags)
File
"/Users/georgweber/Public/sage/sage-3.2.3/local/bin/ncadoctest.py", line
1172, in run_one_example
compileflags, 1) in test.globs
File "<doctest __main__.example_14[22]>", line 1, in <module>
E.quadratic_twist(-Integer(19)).label()###line 644:
sage: E.quadratic_twist(-19).label()
File "/Users/georgweber/Public/sage/sage-3.2.3/local/lib/python2.5
/site-packages/sage/schemes/elliptic_curves/ell_rational_field.py", line
2720, in cremona_label
raise RuntimeError, "Cremona label not known for %s."%self
RuntimeError: Cremona label not known for Elliptic Curve defined by
y^2 + y = x^3 - x^2 - 120*x - 2183 over Rational Field.
**********************************************************************
1 items had failures:
1 of 23 in __main__.example_14
***Test Failed*** 1 failures.
}}}
The doctest failure above seems to come from that I used a vanilla Sage
3.2.3, and the example seems to need the optional extended Cremona tables
--- so just add a "#optional" or so.
There are also a bunch of doctest failures for "sha_tate.py", which pop up
(only) if the doctest "-long" option is used.
{{{
sage -t -long "local/lib/python/site-
packages/sage/schemes/elliptic_curves/sha_tate.py"
**********************************************************************
File "/Users/georgweber/Public/sage/sage-3.2.3/local/lib/python/site-
packages/sage/schemes/elliptic_curves/sha_tate.py", line 276:
sage: EllipticCurve('123a1').sha().an_padic(41) #rank 1 (long time)
Expected:
1 + O(41)
Got:
40 + O(41)
**********************************************************************
File "/Users/georgweber/Public/sage/sage-3.2.3/local/lib/python/site-
packages/sage/schemes/elliptic_curves/sha_tate.py", line 283:
sage: EllipticCurve('34a1').sha().an_padic(5) # rank 0 (long time)
Exception raised:
.......
sage: EllipticCurve('34a1').sha().an_padic(5) # rank 0 (long time)
File "/Users/georgweber/Public/sage/sage-3.2.3/local/lib/python2.5
/site-packages/sage/schemes/elliptic_curves/sha_tate.py", line 394, in
an_padic
lps = lp.Dp_valued_series(n,quadratic_twist=D,prec=r+1)
TypeError: Dp_valued_series() got an unexpected keyword argument
'quadratic_twist'
........
sage: e.sha().p_primary_bound(7) # long time
File "/Users/georgweber/Public/sage/sage-3.2.3/local/lib/python2.5
/site-packages/sage/schemes/elliptic_curves/sha_tate.py", line 458, in
p_primary_bound
shan = self.an_padic(p,prec = 0,use_twist=True)
TypeError: an_padic() got an unexpected keyword argument 'use_twist'
}}}
Except for the first (which might be architecture related, the old file
had this doctest with a "#random" comment --- I'm using a Mac) all the
following "long" doctest failures in sha_tate.py just seem to be artifacts
from development, easily to be cleaned up.
All in all: nothing serious, but as-is it can't go in.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4667#comment:5>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
