#5018: [with package, needs work] lrs optional package improvements
---------------------------------------+------------------------------------
Reporter: mhampton | Owner: mabshoff
Type: enhancement | Status: new
Priority: minor | Milestone: sage-3.3
Component: optional packages | Resolution:
Keywords: lrs, polyhedra, polytopes |
---------------------------------------+------------------------------------
Changes (by mabshoff):
* summary: [with package, needs review] lrs optional package
improvements => [with package, needs work] lrs
optional package improvements
Comment:
A couple remarks:
* the spkg is missing an hg repo. Please check in everything but src
* SPKG.txt does not conform to the standard - see the SpkgTemplate in the
wiki
* spkg-install needs to be executable
* spkg-check is missing, when you add it please run {{{make check}}} with
it
* for the make check target: create foo.expected and direct the result
from test foo into foo.result. Then diff, i.e. do not create the expected
result in the script
* the makefile should have a make install target
* the makefile still uses {{{gcc -O3 -static}}} - this should be set via
CC and CFLAGS for example
Not all of the above have to be fixed to get a positive review from me,
but it would be nice to get those all fixed. The missing hg repo and an
updated SPKG.txt should *really* be done.
Cheers,
Michael
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5018#comment:2>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
