#545: [with patch, positive review] polish the new symbolic logic code.
------------------------------+---------------------------------------------
Reporter: was | Owner: chrisgorecki
Type: enhancement | Status: new
Priority: major | Milestone: sage-3.3
Component: basic arithmetic | Resolution:
Keywords: editor_wstein |
------------------------------+---------------------------------------------
Changes (by GeorgSWeber):
* summary: [with patch, needs review] polish the new symbolic logic
code. => [with patch, positive review] polish
the new symbolic logic code.
* milestone: sage-3.4.1 => sage-3.3
Comment:
Positive review, this should go into the 3.3 series.
@Michael:
For this ticket, only two of the patches are to be applied (I tested
against Sage3.3.alpha0 on my Mac) to the Sage Library (devel/sage-main):
* "logic4.patch" (should apply cleanly, credit: Chris Gorecki)
* "trac_545_latex.patch" (should apply, but with one hunk succeeding only
with fuzz, credit: Wilfried Huss)
Note 1: The "logic4.patch" is essentially the "logic3.patch", but such
that the files do not go into "devel/sage/logic/", but into
"devel/sage/sage/logic", where they belong. For the doctests to pass I
also changed lines like "sage: import propcalc" into "sage: import
sage.logic.propcalc as propcalc", and I removed linebreaks/backslashes in
the "Expected Output" so that the true output now does match the expected
output. Probably one should adjust the "all.py" in the "sage/logic"
subdirectory in an appropriate way, but I wanted to do only minimal
invasive changes to the original ("logic3") patch.
Note 2: I have not tried any ReSTification. But I would rather have it in
3.4 without Sphinx documentation, than having to rewrite the patches for
this ticket for 3.4.1 again, given the age of the ticket. Wil might have
an opinion on that.
Note 3: One of the six new files, the file "boolopt.py", says in it:
"Copyright 2006 (c) Michael Greenberg. NewBSD license, listed below ...".
The terms listed are definitely compatible with GPLv2+, as far as I can
tell, but IANAL. (The other five files are entirely written by Chris
Gorecki, and are "Distributed under the terms of the GNU General Public
License (GPL)".)
Note 4: This "other" file boolopt.py misses doctests on its own, but the
functionality provided is well tested implicitly by using it in other ones
of these six files. This is OK from my side, but probably a
"""nodoctests""" should be added --- or the code has to be refactored on a
larger scale --- or this one file would have to be put in its own micro-
spkg.
Note 5: There definitely is further work to be done on the "sage/logic/"
part of Sage, e.g. the old "logic.py" file most probably should be thrown
out, "all.py" should be adjusted, and so on. But please, please, please
open new tickets for that!
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/545#comment:36>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
