#3321: [with patch, positive review] Matrix.visualize_structure is too
dark/messed
up
--------------------+-------------------------------------------------------
Reporter: malb | Owner: cwitty
Type: defect | Status: new
Priority: major | Milestone: sage-3.3
Component: misc | Resolution:
Keywords: |
--------------------+-------------------------------------------------------
Changes (by mabshoff):
* summary: [with patch, needs review] Matrix.visualize_structure is too
dark/messed up => [with patch, positive review]
Matrix.visualize_structure is too dark/messed
up
* milestone: sage-3.4.1 => sage-3.3
Comment:
Replying to [comment:2 ddrake]:
> This fixes the bug and the code is fine, but in the docstring I have a
minor quibble: you remove a warning about libpng problems on OS X. If
those problems haven't been fixed, we should leave the warning in the
docstring. I'll give this a positive review if you put the little warning
back (or show that the problem was fixed!)
The problem has been fixed, which is the reason the libpng.dylib problem
pops up with various external packages. It was the tradeoff between the
Sage library passing doctests and external code working, so I chose Sage.
Hence this is positive review.
Cheers,
Michael
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/3321#comment:3>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
