#5041: [with patch; needs review] make it so the magma .sig files in extcode
don't
get written there by magma
------------------------+---------------------------------------------------
Reporter: was | Owner: was
Type: defect | Status: new
Priority: blocker | Milestone: sage-3.3
Component: interfaces | Resolution:
Keywords: |
------------------------+---------------------------------------------------
Changes (by was):
* summary: make it so the magma .sig files in extcode don't get written
there by magma => [with patch; needs review]
make it so the magma .sig files in extcode
don't get written there by magma
Comment:
The attached patch does the following:
(1) Deletes magma/ell_padic and magma/padic_height which were only there
for p-adic height computations before sage got its own much better native
code. Also, deletes the file
SAGE_ROOT/devel/sage/sage/schemes/elliptic_curves/ell_padic.py, which was
slated for deprecation officially several months ago, and just wraps those
files.
AND
(2) The first (and only first) time a Magma interface is started in a
given session, it copies over data/extcode/magma to a temp directory.
This directory is only 52 kilobytes, so this is fast and easy. It will
not grow much, since it is all hand written. This is new code in
magma.py. It's just a few lines. By doing this, all extcode code for
mamga that we ever write can easily be attached without permission issues.
TO TEST:
(0) Apply all patches
(1) doctest elliptic curves to make sure my removal of deprecated code
didn't break anything:
{{{
$ sage -tp 3 devel/sage/sage/schemes/elliptic_curves/
}}}
(2) doctest the entire magma interface optional test code to make sure I
didn't break anything:
{{{
$ ./sage -t -only_optional=magma devel/sage/sage/
}}}
(3) Read the source code modified in my patch to magma.py.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5041#comment:1>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
