#4524: [with patch, positive review pending doc fixes] interact : incomplete
default string in the input box
-----------------------+----------------------------------------------------
Reporter: slabbe | Owner: mhansen
Type: defect | Status: assigned
Priority: major | Milestone: sage-3.4.1
Component: interact | Resolution:
Keywords: input_box |
-----------------------+----------------------------------------------------
Changes (by slabbe):
* summary: [with patch, needs review] interact : incomplete default
string in the input box => [with patch,
positive review pending doc fixes] interact :
incomplete default string in the input box
Comment:
First, that is the first time I review a patch. So if you have comment on
the way I review, tell me. I also have some questions that I write below
as I have them. Moreover, I am not familiar with notebook code at
all....so should I let the job to somebody else?
However, I applied the patch and I can at least say that the problem I
submitted is now fixed which is cool!
There is a small issue here (double that) :
{{{
Note that any HTML that that uses quotes around this should use double
quotes and not single quotes.
}}}
Also, I don't know if you agreee, but I suggest to add the second example
below :
{{{
EXAMPLES:
sage: from sage.server.notebook.interact import InteractControl
sage: InteractControl('x', '"cool"').html_escaped_default_value()
'"cool"'
sage: InteractControl('x',"'cool'").html_escaped_default_value()
"'cool'"
}}}
My last question is : I could have posted a patch for both issues (double
that, and the 2nd example). What is commonly done? Do we leave the changes
to the patcher?
My statement is Positive review pending fixes on at least the first of my
two doc-suggestions.
Thanks for the fix,
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4524#comment:2>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
