#545: [with patch, needs work] polish the new symbolic logic code.
------------------------------+---------------------------------------------
Reporter: was | Owner: chrisgorecki
Type: enhancement | Status: reopened
Priority: major | Milestone: sage-3.3
Component: basic arithmetic | Resolution:
Keywords: editor_wstein |
------------------------------+---------------------------------------------
Comment (by GeorgSWeber):
Thanks for catching the two "long" doctest failures I let slip by. They're
indeed trivial to fix.
Concerning the coverage: I'm at a loss here.
Please see my "Note 4" from above about the file "boolopt.py", which would
have either to be refactored (i.e. rewritten) completely, or one would
have to add lots of meaningless doctests, look at the following code
snippet:
{{{
def visit_prop(self, node, children):
self.props.add(children[0])
def visit_notprop(self, node, children):
self.props.add(children[0])
def transform_node(self, node, children):
return [[tuple([node] + children)]]
def transform_or(self, node, children):
return children[0] + children[1]
}}}
Thoughts?
Cheers, gsw
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/545#comment:39>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
