#3762: [with patch, positive review] remove quaddouble from sage -- not used,
source of pain, mpfr is better
--------------------------+-------------------------------------------------
Reporter: was | Owner: mabshoff
Type: enhancement | Status: new
Priority: major | Milestone: sage-3.3
Component: distribution | Resolution:
Keywords: |
--------------------------+-------------------------------------------------
Changes (by was):
* summary: [with patch, needs review] remove quaddouble from sage -- not
used, source of pain, mpfr is better => [with
patch, positive review] remove quaddouble from
sage -- not used, source of pain, mpfr is
better
* milestone: sage-3.4.1 => sage-3.3
Comment:
1. I applied this to sage-3.3.alpha1 on sage.math and got:
{{{
The following tests failed:
sage -t devel/sage/sage/rings/complex_field.py # 1 doctests
failed
sage -t devel/sage/sage/structure/sage_object.pyx # 1 doctests
failed
----------------------------------------------------------------------
Total time for all tests: 164.0 seconds
wst...@sage:/scratch/wstein/sage-3.3.alpha1$
}}}
We have:
{{{
sage -t
devel/sage/sage/structure/sage_object.pyx**********************************************************************
File "/scratch/wstein/sage-3.3.alpha1/devel/sage-
main/sage/structure/sage_object.pyx", line 682:
sage: sage.structure.sage_object.unpickle_all(std)
Expected:
doctest:...: DeprecationWarning: Your data is stored in an old format.
Please use the save() function to store your data i
n a more recent format.
Successfully unpickled ... objects.
Failed to unpickle 0 objects.
Got:
doctest:1172: DeprecationWarning: Your data is stored in an old
format. Please use the save() function to store your data
in a more recent format.
doctest:1172: DeprecationWarning: RQDF is deprecated; use
RealField(212) instead.
Successfully unpickled 448 objects.
Failed to unpickle 0 objects.
**********************************************************************
1 items had failures:
1 of 7 in __main__.example_16
***Test Failed*** 1 failures.
sage -t devel/sage/sage/rings/complex_field.py
**********************************************************************
File "/scratch/wstein/sage-3.3.alpha1/devel/sage-
main/sage/rings/complex_field.py", line 105:
sage: C(RR.log2(), RR.e())
Exception raised:
Traceback (most recent call last):
File "/scratch/mabshoff/sage-3.3.alpha1/local/bin/ncadoctest.py",
line 1231, in run_one_test
self.run_one_example(test, example, filename, compileflags)
File "/scratch/mabshoff/sage-3.3.alpha1/local/bin/sagedoctest.py",
line 38, in run_one_example
OrigDocTestRunner.run_one_example(self, test, example, filename,
compileflags)
File "/scratch/mabshoff/sage-3.3.alpha1/local/bin/ncadoctest.py",
line 1172, in run_one_example
compileflags, 1) in test.globs
File "<doctest __main__.example_2[7]>", line 1, in <module>
C(RR.log2(), RR.e())###line 105:
sage: C(RR.log2(), RR.e())
AttributeError: 'sage.rings.real_mpfr.RealField' object has no
attribute 'e'
**********************************************************************
1 items had failures:
}}}
2. Performance on sage.math:
{{{
BEFORE:
sage: time k = number_of_partitions(10^8)
CPU times: user 2.48 s, sys: 0.00 s, total: 2.48 s
Wall time: 2.49 s
sage: time k = number_of_partitions(10^9)
CPU times: user 22.85 s, sys: 0.00 s, total: 22.85 s
Wall time: 22.85 s
AFTER:
sage: time k = number_of_partitions(10^8)
CPU times: user 3.29 s, sys: 0.00 s, total: 3.29 s
Wall time: 3.29 s
sage: time k = number_of_partitions(10^9)
CPU times: user 35.68 s, sys: 0.00 s, total: 35.68 s
Wall time: 35.71 s
}}}
3. I read all the code in the patches, and am fine with it.
Positive review if the two doctest issues above are fixed.
NOTE: you should not delete the quaddouble package, since this code still
links it in. That will have to happen in a few months after Deprecation.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/3762#comment:5>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
