#4964: [with patch, with review, needs work] Add Weil pairing to Sage
-------------------------------------+--------------------------------------
Reporter: dmhansen | Owner: mollerhansen
Type: enhancement | Status: reopened
Priority: minor | Milestone: sage-3.3
Component: algebraic geometry | Resolution:
Keywords: pairing, elliptic curve |
-------------------------------------+--------------------------------------
Comment (by cremona):
Replying to [comment:9 dmhansen]:
> > Is there a typo in the code perhaps?
>
> Well, I kinda hope that there is, since otherwise it would be a larger
problem.
> Debugging time! I'll try to figure it out, then i'll put up a new patch
and notify you. Thanks for your review.
I cannot see the problem myself. The _line_() code looks fine.
_miller_() looks good, and when the points are independent I don't see how
you would ever get 0 from one of the _line() calls. [One piece of
debugging would be to make sure that _line_() never returns zero,
perhaps).
Two more comments: in _miller_(), you should perhaps initialize t to
self.base_ring()(1) and not just 1. Secondly, this code would apply just
as well to points of finite order over any field, so you should move the
whole block of code so that the functions are members of
EllipticCurvePoint_field and not of the sub-class
EllipticCurvePoint_finite_field.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4964#comment:10>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
