#4805: [with new patch, needs review] S_integral points failure (possible p-adic
precision problem)
----------------------------+-----------------------------------------------
Reporter: cremona | Owner: was
Type: defect | Status: new
Priority: major | Milestone: sage-3.3
Component: number theory | Resolution:
Keywords: elliptic curve |
----------------------------+-----------------------------------------------
Changes (by cremona):
* summary: [with patch, needs work] S_integral points failure (possible
p-adic precision problem) => [with new patch,
needs review] S_integral points failure
(possible p-adic precision problem)
Comment:
The second patch should be applied after the first, which still applies ok
to 3.3.alpha3 (with some fuzz). It does the following:
1. In has_good_reduction() I added the originally intended behaviour
when P=None to match the docstring, and added two doctests (one over Q,
one over a number field) which test this. In this function I also deleted
the duplicated lines of code.
2. In padic_elliptic_logarithm() I changed the parameter name from
precision to absprec, corrected the docstring, and added a TODO note
admitting the function's imperfections.
3. In S_integral_points() I removed the now redundant NOTE and fixed
the bare "except".
I think that's it and hope that RoeD will allow this through, with the
admission that a new version of padic_elliptic_logarithm() which handles
precision better would certainly be desirable.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4805#comment:7>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---