#4544: [with patch, positive review] comparison of CDF (or any inexact) elements
needs fixing
------------------------+---------------------------------------------------
Reporter: craigcitro | Owner: jkantor
Type: defect | Status: new
Priority: blocker | Milestone: sage-3.3
Component: numerical | Resolution:
Keywords: |
------------------------+---------------------------------------------------
Changes (by mabshoff):
* summary: [with patch, needs review] comparison of CDF (or any inexact)
elements needs fixing => [with patch, positive
review] comparison of CDF (or any inexact)
elements needs fixing
Comment:
Patch looks good to me. It applies to my 3.3.alpha5 merge tree, but there
is one doctest failure due to recently merged code:
{{{
sage -t -long "devel/sage/sage/calculus/calculus.py"
**********************************************************************
File
"/Users/mabshoff/sage-3.3.alpha4/devel/sage/sage/calculus/calculus.py",
line 3206:
sage: f.roots(ring=CC)
Expected:
[(-0.0588115223184495, 1), (1.36050567903502 + 1.51880872209965*I, 1),
(-1.331099917875... + 1.52241655183732*I, 1), (1.36050567903502 -
1.51880872209965*I, 1), (-1.33109991787580 - 1.52241655183732*I, 1)]
Got:
[(-0.0588115223184495, 1), (-1.33109991787579 - 1.52241655183732*I,
1), (-1.33109991787579 + 1.52241655183732*I, 1), (1.36050567903502 -
1.51880872209965*I, 1), (1.36050567903502 + 1.51880872209965*I, 1)]
**********************************************************************
File
"/Users/mabshoff/sage-3.3.alpha4/devel/sage/sage/calculus/calculus.py",
line 3210:
sage: f.roots(ring=CC, multiplicities=False)
Expected:
[-0.0588115223184495, 1.36050567903502 + 1.51880872209965*I,
-1.331099917875... + 1.52241655183732*I, 1.36050567903502 -
1.51880872209965*I, -1.33109991787580 - 1.52241655183732*I]
Got:
[-0.0588115223184495, -1.33109991787579 - 1.52241655183732*I,
-1.33109991787579 + 1.52241655183732*I, 1.36050567903502 -
1.51880872209965*I, 1.36050567903502 + 1.51880872209965*I]
**********************************************************************
File
"/Users/mabshoff/sage-3.3.alpha4/devel/sage/sage/calculus/calculus.py",
line 3214:
sage: f.roots(ring=QQbar, multiplicities=False)
Expected:
[-0.05881152231844944?, 1.360505679035020? + 1.518808722099650?*I,
-1.331099917875796? + 1.522416551837318?*I, 1.360505679035020? -
1.518808722099650?*I, -1.331099917875796? - 1.522416551837318?*I]
Got:
[-0.05881152231844944?, -1.331099917875796? - 1.522416551837318?*I,
-1.331099917875796? + 1.522416551837318?*I, 1.360505679035020? -
1.518808722099650?*I, 1.360505679035020? + 1.518808722099650?*I]
**********************************************************************
}}}
I will post a reviewers patch to fix that issue shortly.
Cheers,
Michael
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4544#comment:5>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
