#5208: [with patch, positive review] Differing behavior for matrix left_kernel 
vs.
right_kernel
-----------------------------------------------+----------------------------
 Reporter:  rbeezer                            |        Owner:  rbeezer 
     Type:  defect                             |       Status:  new     
 Priority:  minor                              |    Milestone:  sage-3.3
Component:  linear algebra                     |   Resolution:          
 Keywords:  matrix, left_kernel, right_kernel  |  
-----------------------------------------------+----------------------------
Comment (by rbeezer):

 Replying to [comment:3 mhansen]:

 I agree that the orginal phrasing is awkward to read the first time you
 see it.  But it's lots of places, in the matrix code it occurs this way
 whenever the cache is queried.  Across all of the source, grep gives me
 627 instances of "is None", with 606 of those being "is not None"

 Should we engage the battle here with these three instances?  ;-)  I'd be
 happy to add another patch (though I'm not sure how to mark the title).

 > Looks good to me.
 >
 > One little thing which doesn't matter too much:
 >
 > {{{
 > if K is not None:
 > }}}
 >
 > is a bit easier to read than
 >
 > {{{
 > if not K is None:
 > }}}

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5208#comment:4>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of 
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to