#5239: [with patch, positive review] Sage 3.3.rc0: even more numerical noise in
sage/sage/plot/plot.py
----------------------+-----------------------------------------------------
Reporter: mabshoff | Owner: mabshoff
Type: defect | Status: assigned
Priority: blocker | Milestone: sage-3.3
Component: doctest | Resolution:
Keywords: |
----------------------+-----------------------------------------------------
Changes (by jason):
* summary: [with patch, needs review] Sage 3.3.rc0: even more numerical
noise in sage/sage/plot/plot.py => [with patch,
positive review] Sage 3.3.rc0: even more
numerical noise in sage/sage/plot/plot.py
Comment:
This patch looks trivial enough. The changes look reasonable, and
mabshoff ran the doctests, so positive review.
{{{
[04:09] <jason--> I got rejects on 5239
[04:09] <mabs> Mhhh
[04:10] <mabs> I build against rc0.
[04:10] <jason--> yeah, I have a messed up rc0
[04:10] <mabs> Well, I patched against rc0.
[04:10] <mabs> Ok
[04:10] <mabs> It works, trust me :)
[04:10] <jason--> can I give this a "I looked at it" positive review?
[04:10] <mabs> Yes, just don't tell anyone.
[04:10] <mabs> :)
[04:10] <jason--> okay, I'll whisper it very quietly on the ticket.
[04:11] <jason--> (with this IRC log :)
[04:11] <mabs> I do have the same OS, compiler and hardware as the
reporter and I also took the report to produce the patch.
[04:11] <mabs> And it does fix the issue on my box, so this is a pretty
sure thing.
}}}
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5239#comment:3>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
