#5098: [with patch, with positive review, doctest fix needs review] Pollard rho
algorithm for generic discrete logarithm
-------------------------+--------------------------------------------------
Reporter: ylchapuy | Owner: tbd
Type: enhancement | Status: new
Priority: minor | Milestone: sage-3.3
Component: algebra | Resolution:
Keywords: |
-------------------------+--------------------------------------------------
Comment (by cremona):
I was intending to review this (again), but there are a lot of patches and
I do not know which ones to apply. All?
Regarding the last doctest issue, the function being tested states in its
docstring that the arguments should be units, so surely it would be more
sensible to test that and return an error if not, rather than go ahead and
call any of the generic discrete log functions (which are placed in
sage/GROUPS/generic.py for a reason: they require a group and were written
that way, so inverses would exist). Just because 4 happens to be a power
of 2 mod 100 does not mean that I should be forced to apologise for not
returning an answer in that case. I know of no reason anyone might ever
have for implementing discrete logs for non-units in a non-integral
domain.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5098#comment:21>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
