#5271: [with spkg, positive review] clean up jmol-11.6.16.spkg from #2873
----------------------+-----------------------------------------------------
Reporter: mabshoff | Owner: mabshoff
Type: defect | Status: closed
Priority: major | Milestone: sage-3.3
Component: packages | Resolution: fixed
Keywords: |
----------------------+-----------------------------------------------------
Comment (by mabshoff):
Replying to [comment:4 jason]:
> I based my changes on the jmol spkg that was sitting in my 3.3alpha3
tree, so I'm surprised it wasn't the latest. Anyways, thanks for noticing
this and taking care of it!
Well, it was well worth the update of jmol, I was just not happy at that
point that I had to resolve what had happened. Note that the faulty
.hgignore that lead to many files being ignored by hg was my fault, but I
still do not understand how that happened since I assumed that there was
just one directory to be ignore. Anyway, this spkg is much cleaner,
conforms with the standard packaging rules, i.e. bits in src. Note that I
also blame the reviewed for not catching it, too, since I expect reviewers
of spkgs to verify in the repo that the history is not partially
truncated. But I do it with *every* spkg anyway :)
Cheers,
Michael
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5271#comment:5>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
