#13412: PowerSeriesRing should call Ring.__init__
----------------------------------------------------+-----------------------
Reporter: SimonKing | Owner: nthiery
Type: defect | Status:
needs_review
Priority: major | Milestone: sage-5.4
Component: categories | Resolution:
Keywords: power series, coercion, category | Work issues:
Report Upstream: N/A | Reviewers:
Authors: Simon King | Merged in:
Dependencies: | Stopgaps:
----------------------------------------------------+-----------------------
Comment (by nthiery):
Hi Simon,
I am not sure I'll get through the review, but I am now browsing through
the patch while Sage compiles C3. Here are some little comments:
Near the TestSuite calls, I see things like:
{{{
sage: loads(dumps(X)) is X
True
}}}
This is a generic test, so I'd rather not include those, and if you feel
strong about them to add it as a generic test in the TestSuite. Maybe the
X._test_pickling() should check whether X has unique representation, and
test with `is` or `==` accordingly? Or instead one could just check
elsewhere that equality is indeed defined in term of ``is`` (like testting
whether the __eq__ method is that inherited from UniqueRepresentation)
line 362: this should be {{{is_MPowerSeriesRing(S)}}}:
{{{
if (is_MPolynomialRing(S) or is_MPowerSeriesRing)
}}}
Cheers,
Nicolas
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13412#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
