#13510: Small change to graph_is_strongly_regular (return the number of 
vertices)
---------------------------------+------------------------------------------
       Reporter:  ncohen         |         Owner:  jason, ncohen, rlm
           Type:  enhancement    |        Status:  needs_review      
       Priority:  major          |     Milestone:  sage-5.4          
      Component:  graph theory   |    Resolution:                    
       Keywords:                 |   Work issues:                    
Report Upstream:  N/A            |     Reviewers:                    
        Authors:  Nathann Cohen  |     Merged in:                    
   Dependencies:                 |      Stopgaps:                    
---------------------------------+------------------------------------------

Comment (by rbeezer):

 I'd say this is the '''right''' thing to return, it is extremely standard
 to quote all four at once.  At a minimum it is a big improvement.  Two
 initial comments.

 1.  Patch has some changes to `coloring.py` that look totally unrelated.
 Should they be somewhere else?
 1.  What if somebody currently does
 {{{
 g.is_strongly_regular(return_parameters = True)[1]
 }}}
 because all they want is `lambda`.  Now they will get `k` and be none the
 wiser.  How about deprecating the current keyword and make up a new
 (similar) one?  Or maybe there is a better fix that I am not thinking of
 right now.  (There is an easy decorator for deprecating a keyword, iirc.)
 Just `parameters` would be cleaner, imho.

 Rob

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13510#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to