#6391: libGAP! -- create a Cython library interface to gap
----------------------------------------------------------------------------+
Reporter: was |
Owner: was
Type: enhancement |
Status: needs_work
Priority: major |
Milestone: sage-5.5
Component: group theory |
Resolution:
Keywords: |
Work issues: assert usage
Report Upstream: N/A |
Reviewers: Dima Pasechnik, Ivan Andrus, Volker Braun, William Stein
Authors: Dima Pasechnik, Ivan Andrus, Volker Braun, William Stein |
Merged in:
Dependencies: #13123, #13211 |
Stopgaps:
----------------------------------------------------------------------------+
Changes (by jdemeyer):
* status: positive_review => needs_work
* work_issues: => assert usage
Comment:
As I said on a different ticket, `assert` should not be used for control
flow. An assert checks something which should always be true, a failed
assertion is always a bug. I consider the following to be bad usage of
`assert`:
{{{
try:
sig_on()
proxy = make_GapElement_MethodProxy(self.parent(),
gap_eval(name),
self)
sig_off()
assert proxy.is_function()
except RuntimeError, AssertionError:
raise AttributeError, 'Name "'+str(name)+'" does not define a
GAP function.'
return proxy
}}}
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/6391#comment:122>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
