#5457: Refactor symmetric functions and k-bounded subspace
----------------------------------------------------------------+-----------
Reporter: nthiery |
Owner: mhansen
Type: enhancement |
Status: closed
Priority: major |
Milestone: sage-5.4
Component: combinatorics |
Resolution: fixed
Keywords: symmetric functions, days38, sd40 | Work
issues:
Report Upstream: N/A |
Reviewers: Dan Bump, Nicolas M. Thiéry, Jeroen Demeyer
Authors: Mike Zabrocki, Anne Schilling, Jason Bandlow | Merged
in: sage-5.4.beta0
Dependencies: #11563, #13109, #12969 |
Stopgaps:
----------------------------------------------------------------+-----------
Comment (by nthiery):
Hi Jeroen,
Replying to [comment:97 jdemeyer]:
> This patch abuses `assert` and `AssertionError`. `assert` should not be
used for control flow. An `assert` checks something which should always be
true, a failed assertion is always a bug in the program.
>
> For example:
> {{{
> sage: f.skew_by([1])
> Traceback (most recent call last):
> ...
> AssertionError: x needs to be a symmetric function
> }}}
> This is a simple user mistake, for which `assert` is not right.
>
> I think this must be fixed
Given the discussion on sage-devel, do we agree that there is no control
flow involved and it's a not so common function, so it's ok to use assert?
Cheers,
Nicolas
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5457#comment:98>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
