#13461: Another WeylCharacterRing speedup
---------------------------------+------------------------------------------
Reporter: bump | Owner: bump
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.4
Component: combinatorics | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers:
Authors: Daniel Bump | Merged in:
Dependencies: | Stopgaps:
---------------------------------+------------------------------------------
Comment (by aschilling):
I can confirm that this patch gives a major speedup for the long tests in
/combinat/root_systems/weyl_characters.py:
28.6 seconds versus 69.9 seconds
Without the long option I get 13.4 seconds versus 12.1 seconds.
Here are a couple of comments on the patch:
- Nicolas taught me that the standard doc strings should have a one-line
description, followed by the INPUT and then, if necessary, a longer
description. It might be good to follow these standards.
- Do you want to keep the "debug" options in _demazure_helper? If so,
please give a short description of what it is for and a doc test with it.
- In demazure_character you refer to analogous methods in WeightRing
elements and as methods of crystals. It might be good to link these using
:meth:, so this is an easy click in the documentation.
- Would it make sense to briefly explain how the notation in
{{{
sage: A2=WeylCharacterRing("A2",style="coroots")
sage: sage: h=sum(A2.fundamental_weights())
sage: A2.demazure_character(h,word=[1,2])
a2(0,0) + a2(-2,1) + a2(2,-1) + a2(1,1) + a2(-1,2)
}}}
and
{{{
sage: C = CrystalOfTableaux(['A',2],shape=[2,1])
sage: C.demazure_character([1,2],reduced_word=True)
x1^2*x2 + x1^2*x3 + x1*x2^2 + x1*x2*x3 + x2^2*x3
}}}
match?
- The description of the patch trac_13461-demazure-lusztig.patch seems to
refer to itself "Depends on trac_13461-demazure-lusztig.patch". Perhaps it
is best to fold both patches.
- There is a spurious "xo" in line 548 in trac_13461-demazure-
lusztig.patch.
- It might be good to use REFERENCES: for the references in
demazure_lusztig. It currently does not read well after `sage -docbuild
reference html`.
So much for now!
Anne
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13461#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
