#9191: Running pyx files from the command line doesn't work anymore
-------------------------------------------------------+--------------------
       Reporter:  was                                  |         Owner:  jason  
     
           Type:  defect                               |        Status:  
needs_review
       Priority:  major                                |     Milestone:  
sage-5.4    
      Component:  misc                                 |    Resolution:         
     
       Keywords:                                       |   Work issues:         
     
Report Upstream:  N/A                                  |     Reviewers:         
     
        Authors:  Karl-Dieter Crisman, Jeroen Demeyer  |     Merged in:         
     
   Dependencies:                                       |      Stopgaps:         
     
-------------------------------------------------------+--------------------

Comment (by kcrisman):

 Wow, nice work!  Very minor concerns below.

 ----

 I'm a little concerned about why .pyx files worked before anyway.  Did it
 just make it to the
 {{{
 os.execv(os.path.join(binpath, 'sage-python'), ['sage-python', fn] + opts)
 }}}
 line and `sage -python` (which is all `sage-python` is) just knew what to
 do with it?  And this is better for some reason for pyx files, right?

 Also, any reason for making the messages print to stderr when they aren't
 errors?  As well as for changing things to the 'new' print statements?  I
 guess you did the work so I shouldn't complain :) but it always means I
 worry about missing some small detail.

 Finally, if you're going to add pyx files to those which this command
 does, you should probably add a testing part to the doctest patch for that
 as well...

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9191#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to