#13459: spkg/bin/sage: do not change directory
----------------------------------+-----------------------------------------
       Reporter:  jdemeyer        |         Owner:  leif           
           Type:  enhancement     |        Status:  positive_review
       Priority:  major           |     Milestone:  sage-5.4       
      Component:  scripts         |    Resolution:                 
       Keywords:                  |   Work issues:                 
Report Upstream:  N/A             |     Reviewers:  John Palmieri  
        Authors:  Jeroen Demeyer  |     Merged in:                 
   Dependencies:                  |      Stopgaps:                 
----------------------------------+-----------------------------------------
Changes (by jhpalmieri):

  * status:  needs_review => positive_review
  * reviewer:  => John Palmieri


Comment:

 Okay, this looks pretty good to me. I might prefer some more comments in
 spkg/bin/sage, for example pointing out that sage-bdist needs to be run
 from SAGE_ROOT. (I'm not actually sure that it does, actually: if run from
 somewhere else, it just creates the temporary directories in the current
 working directory, but maybe it will still work. I guess for the principle
 of least surprise, we shouldn't change the behavior of building in
 SAGE_ROOT/tmp/.)

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13459#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to