#13578: Generator for Ringed-Tree graphs
---------------------------------+------------------------------------------
Reporter: dcoudert | Owner: jason, ncohen, rlm
Type: enhancement | Status: positive_review
Priority: minor | Milestone: sage-5.5
Component: graph theory | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers: Nathann Cohen
Authors: David Coudert | Merged in:
Dependencies: #13306 | Stopgaps:
---------------------------------+------------------------------------------
Changes (by dcoudert):
* status: needs_review => positive_review
* reviewer: => Nathann Cohen
Comment:
> Here is a ... reviewer's patch `:-D`
You have fully rewritten the function in a much smarter way. Thanks!
I was not aware of the circle embedding function. Nice.
> You created a file containing a method "RingedTree", but you called it
"families.py"... If we move all the stuff from graph_generators to
families.py and other files, would you see a problem with putting Robert
Miller's copyright from graph_generators.py at the head of families.py
(and we will do the same at the head of the new files we will create) ?
Otherwise it would be a bit like stealing the copyright just by moving the
code around `^^;`
You are perfectly right. We could may be already put his name and remove
mine.
> If you agree with the patch you can set the ticket to "positive review".
And we will handle all that stuff when we will move the code around !
I agree with the patch. Many thanks.
PS: I have put your name as reviewer, but may be it should be author?
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13578#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
