#12341: Empty (full) cremona database in Sage 4.8 causes tests to fail
-----------------------------------+----------------------------------------
       Reporter:  swenson          |         Owner:  cremona        
           Type:  defect           |        Status:  positive_review
       Priority:  critical         |     Milestone:  sage-5.5       
      Component:  elliptic curves  |    Resolution:                 
       Keywords:                   |   Work issues:                 
Report Upstream:  N/A              |     Reviewers:  John Cremona   
        Authors:  R. Andrew Ohana  |     Merged in:                 
   Dependencies:                   |      Stopgaps:                 
-----------------------------------+----------------------------------------
Changes (by cremona):

  * status:  needs_review => positive_review


Comment:

 There is one small remaining issue here, which admittedly is not caused by
 theis ticket/patch.  Namely, all tests pass with this patch without the
 optional database installed, but when it is installed there is a doctest
 error on line 6454 of elliptic_curves/heegner.py.  That needs to be fixed
 somewhere, so that it passes whether or not the optional db is installed.
 But I am not sure how to do that: it is an example to illustrate a
 specific behaviour, so the usual trick of using a curve whose conductor is
 so large it will not be in the optional database in the forseeable future
 will not do.

 It seems bad to hold up this ticket for this reason!  So I am giving this
 a positive review, and refer to #13547 to address the remaining issue.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12341#comment:29>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to