#13614: Add Table Explaining How To Create Every Group of Order < 32
------------------------------------------+---------------------------------
       Reporter:  khalasz                 |         Owner:  joyner      
           Type:  enhancement             |        Status:  needs_review
       Priority:  minor                   |     Milestone:  sage-5.5    
      Component:  group theory            |    Resolution:              
       Keywords:                          |   Work issues:              
Report Upstream:  N/A                     |     Reviewers:              
        Authors:  Kevin Halasz            |     Merged in:              
   Dependencies:  #13367, #13366, #13365  |      Stopgaps:              
------------------------------------------+---------------------------------

Comment (by rbeezer):

 Kevin,

 Very nice.  This will be a great contribution.  Comments, in order of
 appearance,I think.

 Rob


 1.  Title:  I'd avoid symbols in the title.  Both bad grammar and
 potential text-processing problem.  Maybe "...every group of order 31 or
 less" or "...every group of order less than 32"
 2. "They can all be initiatilized relatively easily." -> "created easily"?
 3.  "permutation groups already implemented in sage" -> "already created"
 or "already initialized"  (implementing is what you are doing)
 4.  "The group outputted by the semidirect product command" -> "output"
 5.  "witheld" - two h's
 6.  "!KleinFourGroup" as description:  C2 x C2 would fit better with the
 remainder (and the command you used has this name in it)
 7.  `D_6` is used for order 14 dicyclic
 8.  I presume you used lists to get multiline output into the table.
 Maybe for a consistent look you should use a one-line list in other
 locations.  Did you try to experiment with any kind of "verbatim" or "pre-
 formatted" code to enforce line breaks on the hunks of code?  Might be
 possible, could be impossible.  At least the lists cut/paste cleanly.  Do
 you need the "sage: " prompts?  Do these get doctested?
 9.  Add your name as author. (At the bottom?)
 10.  Would it be feasible to add the !Thomas/Wood numbers/id to each row
 of the table??  That'd add some credibility.  Should probably reference
 the whole book at a minimum.
 11.  Would it make sense to add some of this as simple doctests, so if a
 key construction function changes, then it'll get relected here?  Right
 now it passes all tests, but I don't think anything is being tested.
 Maybe convert your simple examples at the top from formatted text (double
 back-ticks) to real doctests?  You want your table to stay relevant, even
 if Sage changes.  You could add one test for each construction process,
 which would be both good for reliability and good for instruction.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13614#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to