#5956: image dimensions for show() are in inches
-------------------------------------------------------+--------------------
Reporter: mvngu | Owner: was
Type: defect | Status:
needs_work
Priority: minor | Milestone:
sage-5.4
Component: graphics | Resolution:
Keywords: image dimensions, figsize, beginner | Work issues:
Report Upstream: N/A | Reviewers:
Karl-Dieter Crisman
Authors: Emily Chen | Merged in:
Dependencies: | Stopgaps:
-------------------------------------------------------+--------------------
Changes (by {'newvalue': u'Emily Chen', 'oldvalue': u'emchennyc'}):
* status: needs_review => needs_work
* reviewer: => Karl-Dieter Crisman
* author: emchennyc => Emily Chen
Comment:
This would be a good start.
What's the reference for the dpi, just out of curiosity? (I assume it's
right in the Sage or mpl source.) Also, telling us the maximum possible
would be helpful, given the errors - especially since the one above is
confusing since the `32768` is in "dots", not inches. Presumably if one
reset the default dpi...
{{{
sage: P.show(figsize=[1,327],dpi=100)
sage: P.show(figsize=[1,328],dpi=100)
<ValueError>
sage: P.show(figsize=[1,328],dpi=80)
}}}
So this should be very, very clear, in order to resolve this ticket.
Additionally, you'll want to add a doctest to verify that some things
don't go boom, and that the error is correctly raised, etc. Maybe even a
`# not tested` line with the segfault.
Finally, we may also want to report the segfault upstream with a "pure"
matplotlib example, if you can concoct one.
But all that said, thanks very much for looking at this - this is just
part of the normal review process, good start.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5956#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
