#13687: Parents for groups
--------------------------------+-------------------------------------------
       Reporter:  vbraun        |         Owner:  joyner      
           Type:  enhancement   |        Status:  needs_review
       Priority:  major         |     Milestone:  sage-5.5    
      Component:  group theory  |    Resolution:              
       Keywords:  new Parent    |   Work issues:              
Report Upstream:  N/A           |     Reviewers:  David Roe   
        Authors:  Volker Braun  |     Merged in:              
   Dependencies:                |      Stopgaps:              
--------------------------------+-------------------------------------------

Comment (by roed):

 Looks good.  Two more comments and then I'm happy to give a positive
 review:

 * In docstring for `SFractionalIdealClass`, your example blocks are
 indented.  There should also only be one block rather than three.

 * There's a failure in the startup plugin.  I have no problem giving a
 positive review even so, but I thought I'd point it out in case you wanted
 to change anything related to imports.  :-)

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13687#comment:12>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to