#13518: Additions for sensitivity analysis in glpk_backend
-------------------------------------------------------------------------------+
       Reporter:  christiankuper                                               
|         Owner:  jason, jkantor
           Type:  enhancement                                                  
|        Status:  needs_work    
       Priority:  major                                                        
|     Milestone:  sage-5.4      
      Component:  numerical                                                    
|    Resolution:                
       Keywords:  out-of-kilter, sensitivity analysis, lp, linear programming  
|   Work issues:                
Report Upstream:  N/A                                                          
|     Reviewers:                
        Authors:  Christian Kuper                                              
|     Merged in:                
   Dependencies:                                                               
|      Stopgaps:                
-------------------------------------------------------------------------------+
Changes (by ncohen):

  * status:  needs_review => needs_work


Comment:

 Helloooooooo Christian !

 Thank you for this updated patch !

 Well, there is not much to say at this level...

 * There's a double '-' before your name at the beginning of the file
 * Thank you for the lp->mps fix.. Could you also change the filename,
 which currently ends with .lp ?
 * It feels a bit weird to have a print_* method that does not print
 anything but writes the output to a file. Of course that's how the GLPK
 function is named, so it makes sense... What would you think of modifying
 it just a bit so that it can also "PRINT" the information that is being
 written to a file ? Something like, by default, write the information to a
 file and print it, unless the user explicitely wants the information to be
 written to a file, not displayed ? I can do that in another patch if you
 like the idea and don't want to spend time on it.
 * What about just having ``get_row_dual`` and not
 ``get_constraint_shadow_price``, which is just an alias to it anyway ?
 Besides, get_row_dual is how the GLPK function is named, and this method's
 docstring can mention what a shadow price is at the same time ? And the
 same goes for cols.
 * In the documentation of get_backend, why do you put ``instance`` inside
 of quotes ? We usually do this for python expressions.

 Thank you agaiiiiiiiiiiin ! `:-)`

 Nathann

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13518#comment:15>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to