#12882: Allows a generalized Cartan matrix as input for Dynkin diagrams
-------------------------------------------------------------+--------------
       Reporter:  stumpc5                                    |         Owner:  
sage-combinat
           Type:  enhancement                                |        Status:  
needs_review 
       Priority:  major                                      |     Milestone:  
sage-5.4     
      Component:  combinatorics                              |    Resolution:   
            
       Keywords:  Weyl group, Dynkin diagram, Cartan matrix  |   Work issues:   
            
Report Upstream:  N/A                                        |     Reviewers:   
            
        Authors:  Christian Stump                            |     Merged in:   
            
   Dependencies:                                             |      Stopgaps:   
            
-------------------------------------------------------------+--------------

Comment (by stumpc5):

 Replying to [comment:5 hthomas]:
 > Hi Christian--
 >
 > Your code is checking that all the off-diagonal entries in the input
 matrix are strictly negative.  That seems a bit over-enthusiastic.
 >
 > A doctest for the new functionality would also be good.

 Hi Hugh!

 Thanks for bringing back my/our attention to this ticket!

 I will be too busy to actively work on this patch in the next two weeks,
 but feel free to take it over and review/finish it if you like! I will now
 provide a version that you can work with (in particular, I deleted the
 dependency). Of course, you can as well wait until I finish the patch, if
 you prefer.

 Best, Christian

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12882#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to