#5508: [with patch, positive review, one tiny fix needed] Improvements for
relative number fields
---------------------------+------------------------------------------------
Reporter: fwclarke | Owner: was
Type: enhancement | Status: new
Priority: major | Milestone: sage-3.4.1
Component: number theory | Keywords:
---------------------------+------------------------------------------------
Comment(by cremona):
Review: I read through the patch and was impressed by the thoroughness
and attention to detail! I don't know all the formulas for relative
different (etc) off the top of my head, but what is tere looks reasonable.
The patch applies cleanly to 3.4.
Doctesting sage/rings/number_field, the only problem was this:
{{{
sage -t
"local/sage-3.4/devel/sage-5508/sage/rings/number_field//order.py"
**********************************************************************
File
"/home/masgaj/local/sage-3.4/devel/sage-5508/sage/rings/number_field/order.py",
line 1196:
sage: OK(a)
Expected nothing
Got:
a
**********************************************************************
File
"/home/masgaj/local/sage-3.4/devel/sage-5508/sage/rings/number_field/order.py",
line 1197:
sage: a
Expected nothing
Got:
a
}}}
which is just a matter of deleting a rogue "sage: " prompt in front of one
line of output.
Fix that and this will ready to go. (I hope it merges ok with my units
code at #5513!)
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5508#comment:1>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
