#13517: Voronoi diagrams
------------------------------------+---------------------------------------
Reporter: moritz | Owner: mhampton
Type: enhancement | Status: needs_review
Priority: minor | Milestone: sage-5.4
Component: geometry | Resolution:
Keywords: voronoi delaunay | Work issues:
Report Upstream: N/A | Reviewers:
Authors: Moritz Firsching | Merged in:
Dependencies: | Stopgaps:
------------------------------------+---------------------------------------
Comment (by mmarco):
Thanks for the work, i think it is a nice addition.
A couple of comments though.
-I don't understand why your patch adds the file voronoi_diagram.py.out.
Is that made on purpose or is it a mistake?
-Unless i am missing something, i think that allowing exact fields (like
rationals, or maybe even algebraic reals) should work just the same way.
There is really no need to hard code RDF, it would be better to use the
same field as the given entry. This should be a really trivial change:
just define a self._field as self._points.base_ring(), and then replace
RDF by self._field in the rest of your code.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13517#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
