#8162: p-adic ring constructor documentation incorrect
-----------------------------+----------------------------------------------
Reporter: dmharvey | Owner: roed
Type: defect | Status: needs_review
Priority: minor | Milestone: sage-5.6
Component: padics | Resolution:
Keywords: sd35 | Work issues:
Report Upstream: N/A | Reviewers:
Authors: David Roe | Merged in:
Dependencies: | Stopgaps:
-----------------------------+----------------------------------------------
Comment (by saraedum):
Replying to [comment:7 roed]:
> I can't think of a good reason to allow a list, but also no particular
reason not to allow it, since lists are a common container for objects in
Python. :-)
Sure, this makes sense.
> As for the check parameter, my interpretation of check=False is that it
only accepts input of a particular format in order to minimize the time
spent in handling different input formats. So I think it's completely
reasonable for your example to fail when you don't pass in something of
the form [(p, k)].
I mostly agree with you. I think that with {{{check=False}}} nothing
should be done that could be expensive (things like checking whether a
minimal polynomial is actually irreducible). However, I believe that
{{{check}}} should not have an influence on the interface.
I adapted your patch to only make the check trigger whether we check that
{{{p}}} is actually a prime. All the other checks are just
{{{isinstance}}} and {{{len}}} checks which come essentially for free.
I looked at some timings and the two versions don't really seem to differ
with {{{q=(p,k)}}} and {{{check=False}}}.
Would this patch be acceptable for you?
[I haven't run full doctests yet, so let me see if the patchbot at least
likes it.]
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8162#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
