#5536: [with patch, positive review] trivial docstring patches for permgp.py
--------------------------+-------------------------------------------------
Reporter: jhpalmieri | Owner: jhpalmieri
Type: defect | Status: new
Priority: trivial | Milestone: sage-3.4.1
Component: group_theory | Keywords:
--------------------------+-------------------------------------------------
Comment(by mvngu):
REFEREE REPORT
[[BR]][[BR]]
The patch '''permgp.patch''' applies OK against Sage 3.4 and all doctests
passed with the options
{{{
-t -long
}}}
The reference manual builds fine. Looking at the HTML doc for
{{{sage/groups/perm_gps/permgroup.py}}}, I see that the patch fixes the
formatting issues that it meant to fix. So positive review.
[[BR]][[BR]]
However, while reviewing the patch I noticed that there are more
formatting issues in {{{sage/groups/perm_gps/permgroup.py}}}. But these
are addressed in ticket #5542.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5536#comment:1>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
