#13417: Improved iteration on finite \ZZ-submodules and vector spaces over
finite
fields
---------------------------------------------------------+------------------
Reporter: tfeulner | Owner:
AlexGhitza
Type: enhancement | Status:
positive_review
Priority: major | Milestone:
sage-5.5
Component: algebra | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers:
Punarbasu Purkayastha
Authors: Thomas Feulner, Punarbasu Purkayastha | Merged in:
Dependencies: | Stopgaps:
---------------------------------------------------------+------------------
Changes (by tfeulner):
* status: needs_review => positive_review
Comment:
Replying to [comment:13 ppurka]:
> Ok. The code works, and looks good to me. It is positive review from my
side. I am attaching a [attachment:trac_13417-review.patch review patch]
which does only two changes - get rid of trailing whitespace, and change a
comparison `== None` to `is None`. If you are ok with this patch, then
you can set it to positive review.
These changes look good to me, sorry for the whitespaces.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13417#comment:14>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
