#13741: Proper deallocation of the (unique) pari instance
-------------------------------------+--------------------------------------
       Reporter:  SimonKing          |         Owner:  rlm         
           Type:  defect             |        Status:  needs_review
       Priority:  blocker            |     Milestone:  sage-5.5    
      Component:  memleak            |    Resolution:              
       Keywords:  pari deallocation  |   Work issues:              
Report Upstream:  N/A                |     Reviewers:              
        Authors:  Simon King         |     Merged in:              
   Dependencies:                     |      Stopgaps:              
-------------------------------------+--------------------------------------

Comment (by jpflori):

 Could you just remove the ending newline and use a ..NOTE:: contruction?

 I'm not really sure the shared C-data is really what should be said.
 I'd rather say something like
 "Crafting a direct doctest for this method would entail properly
 deallocating all Sage objects indirectly pointing to the PARI library and
 all C data instantiated at PARI library initialization to be sure that a
 new initialization of the PARI library does not create conflicts.
 The first step is exactly what Python garbage collector will do when
 exiting Sage and can be highly non-trivial.
 The second one is exactly what the __dealloc__ method should do.
 If one of these steps is not performed carefully, then it can lead to
 crashes when Sage exits.
 Therefore, a direct doctest does not provide more evidence on the fact
 that the unique PARI instance is properly deallocated, than the fact that
 Sage does not crash when exiting and we rely on this indirect doctest."

 What do you think?

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13741#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to