#5159: [with new patch, positve review] Add functionality to Galois groups
---------------------------+------------------------------------------------
Reporter: davidloeffler | Owner: davidloeffler
Type: enhancement | Status: assigned
Priority: major | Milestone: sage-3.4.2
Component: number theory | Keywords: galois groups, number theory
---------------------------+------------------------------------------------
Comment(by cremona):
Good news: this patch applies fine on top of sage-5508.2.patch.
I am very happy with this patch which provides a significant new set of
functions and capabilities. I did have two trivial doctest failures, in
two files, nothing serious:
{{{
sage -t
"local/sage-3.4/devel/sage-5159/sage/rings/number_field//number_field.py"
**********************************************************************
File
"/home/masgaj/local/sage-3.4/devel/sage-5159/sage/rings/number_field/number_field.py",
line 3067:
sage: G = k.galois_group(names='c'); G
Expected:
Galois group of Number Field in b with defining polynomial x^3 - x + 1
Got:
Galois group of Galois closure in c of Number Field in b with defining
polynomial x^3 - x + 1
*** Warning: large Minkowski bound: certification will be VERY long.
*** Warning: large Minkowski bound: certification will be VERY long.
*********************************************************************
}}}
and
{{{
sage -t
"local/sage-3.4/devel/sage-5159/sage/rings/number_field//galois_group.py"
**********************************************************************
File
"/home/masgaj/local/sage-3.4/devel/sage-5159/sage/rings/number_field/galois_group.py",
line 479:
sage: from sage.rings.number_field.galois_group_new import
GaloisGroup_subgroup
Exception raised:
Traceback (most recent call last):
File "/home/masgaj/local/sage-3.4/local/bin/ncadoctest.py", line
1231, in run_one_test
self.run_one_example(test, example, filename, compileflags)
File "/home/masgaj/local/sage-3.4/local/bin/sagedoctest.py", line
38, in run_one_example
OrigDocTestRunner.run_one_example(self, test, example, filename,
compileflags)
File "/home/masgaj/local/sage-3.4/local/bin/ncadoctest.py", line
1172, in run_one_example
compileflags, 1) in test.globs
File "<doctest __main__.example_24[2]>", line 1, in <module>
from sage.rings.number_field.galois_group_new import
GaloisGroup_subgroup###line 479:
sage: from sage.rings.number_field.galois_group_new import
GaloisGroup_subgroup
ImportError: No module named galois_group_new
*******************************************************************
}}}
I have put up a small patch which fixes these, so it can have a positive
review.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5159#comment:10>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
