#13808: Gromov hyperbolicity of graphs
----------------------------------------+-----------------------------------
Reporter: dcoudert | Owner: jason, ncohen, rlm
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-5.6
Component: graph theory | Resolution:
Keywords: graph, hyperbolicity | Work issues:
Report Upstream: N/A | Reviewers:
Authors: David Coudert | Merged in:
Dependencies: | Stopgaps:
----------------------------------------+-----------------------------------
Changes (by ncohen):
* status: needs_review => needs_work
Comment:
Here is my current patch, and two comments :
* It would be nice if ``sage -coverage hyperbolicity.pyx`` returned "100%
coverage". I hate to say it, because it often means adding useless tests
just to fit to the metrics `-_-`
* What is the use of _reduce_biconnected_graph compared to goodcores ? The
docstring says that this function, by removing degree 2 vertices whose
neighborhood is an edge, would reduce a complete bipartite graph to an
edge... But no vertex of a complete bipartite graph is adjacent to two
adjacent vertices (a triangle). I do not see how (as the docstring says)
this function does anything different from the good core decomposition
method above.
It would also be better to set this ticket to `need_work` until your have
found out where the bug you found comes from.
Tell me what you think of the changes I made ! They should make the html
doc nicer !
Nathann
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13808#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
