#11635: Ensure that libraries link to the shared version of NTL by default
----------------------------------------------------------+-----------------
       Reporter:  kcrisman                                |         Owner:  tbd 
               
           Type:  defect                                  |        Status:  
needs_review       
       Priority:  minor                                   |     Milestone:  
sage-5.6           
      Component:  cygwin                                  |    Resolution:      
               
       Keywords:  cygwin ntl libtool spkg                 |   Work issues:      
               
Report Upstream:  N/A                                     |     Reviewers:  
Karl-Dieter Crisman
        Authors:  Karl-Dieter Crisman, Jean-Pierre Flori  |     Merged in:      
               
   Dependencies:                                          |      Stopgaps:      
               
----------------------------------------------------------+-----------------
Changes (by kcrisman):

  * reviewer:  => Karl-Dieter Crisman


Comment:

 Okay, I can't give a 100% positive review because I know nothing about
 libtool, but using the upstream solution makes a heck of a lot more sense
 if we don't have to add any other dependencies and just a few files, and
 the pieces I ''do'' understand of it make sense.

 I built 5.5.rc0 with this on sage.math from scratch, and used
 `SAGE_UPGRADING=yes` on my Mac with this spkg in 5.4.rc2, and no doctest
 failures except on `sage/tests/startup.py` on sage.math, where it
 consistently seems to take 2.1 seconds, not less than 2 - but this was
 also true of a 5.4.rc1 build which didn't have this spkg, so it seems like
 there is just a heavy load there or something.  Coupled with its success
 on Cygwin, I am strongly inclined to give this positive review, modulo
 understanding libtool stuff.

 Jeroen, do you get what JP is trying to do and can you give this positive
 review based on that part of the changes in the spkg?

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11635#comment:62>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to