#5500: [with patch, needs review] add remark to tutorial to make defining
functions at the command line much clearer
---------------------------+------------------------------------------------
Reporter: was | Owner: tba
Type: enhancement | Status: new
Priority: major | Milestone: sage-3.4.1
Component: documentation | Keywords:
---------------------------+------------------------------------------------
Comment(by mvngu):
REFEREE REPORT
[[BR]][[BR]]
The patch '''5500-tut.patch''' mostly looks good: it applies OK against
Sage 3.4, but with one doctest failure:
{{{
[mv...@sage ~]$ sage -t -long
scratch/sage-3.4/devel/sage-5500/doc/en/tutorial/tour_help.rst
sage -t -long "devel/sage-5500/doc/en/tutorial/tour_help.rst"
Traceback (most recent call last):
File "/home/mvngu/scratch/sage-3.4/tmp/tour_help.py", line 296, in
<module>
runner=runner)
File "/home/mvngu/scratch/sage-3.4/local/bin/sagedoctest.py", line 54,
in testmod_returning_runner
runner=runner)
File "/home/mvngu/scratch/sage-3.4/local/bin/ncadoctest.py", line 1819,
in testmod_returning_runner
for test in finder.find(m, name, globs=globs, extraglobs=extraglobs):
File "/home/mvngu/scratch/sage-3.4/local/bin/ncadoctest.py", line 839,
in find
self._find(tests, obj, name, module, source_lines, globs, {})
File "/home/mvngu/scratch/sage-3.4/local/bin/ncadoctest.py", line 893,
in _find
globs, seen)
File "/home/mvngu/scratch/sage-3.4/local/bin/ncadoctest.py", line 881,
in _find
test = self._get_test(obj, name, module, globs, source_lines)
File "/home/mvngu/scratch/sage-3.4/local/bin/ncadoctest.py", line 965,
in _get_test
filename, lineno)
File "/home/mvngu/scratch/sage-3.4/local/bin/ncadoctest.py", line 594,
in get_doctest
return DocTest(self.get_examples(string, name), globs,
File "/home/mvngu/scratch/sage-3.4/local/bin/ncadoctest.py", line 608,
in get_examples
return [x for x in self.parse(string, name)
File "/home/mvngu/scratch/sage-3.4/local/bin/ncadoctest.py", line 570,
in parse
self._parse_example(m, name, lineno)
File "/home/mvngu/scratch/sage-3.4/local/bin/ncadoctest.py", line 628,
in _parse_example
self._check_prompt_blank(source_lines, indent, name, lineno)
File "/home/mvngu/scratch/sage-3.4/local/bin/ncadoctest.py", line 715,
in _check_prompt_blank
line[indent:indent+3], line))
ValueError: line 9 of the docstring for __main__.example_0 lacks blank
after ...: ' ...: return n%Integer(2) == Integer(0)'
[3.3 s]
exit code: 1024
----------------------------------------------------------------------
The following tests failed:
sage -t -long "devel/sage-5500/doc/en/tutorial/tour_help.rst"
Total time for all tests: 3.3 seconds
}}}
This is caused by the following lines in the patch:
{{{
- ... return n%2 == 0
+ ...: return n%2 == 0
+ ...:
}}}
The other patch '''trac_5500-referee.patch''' should fix the above doctest
failure.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5500#comment:2>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
