#12179: Binomial of integer (mod n) returns integer
----------------------------------------------------+-----------------------
       Reporter:  scotts                            |         Owner:  
AlexGhitza                                                        
           Type:  defect                            |        Status:  
needs_review                                                      
       Priority:  major                             |     Milestone:  sage-5.6  
                                                        
      Component:  basic arithmetic                  |    Resolution:            
                                                        
       Keywords:  binomial coefficient modulo sd35  |   Work issues:  rebase on 
top of #11417, reST formatting issue, improve efficiency
Report Upstream:  N/A                               |     Reviewers:  Colton 
Pauderis, Johan Bosman, Marco Streng                       
        Authors:  Sam Scott                         |     Merged in:            
                                                        
   Dependencies:  #11417                            |      Stopgaps:            
                                                        
----------------------------------------------------+-----------------------
Changes (by scotts):

  * status:  needs_work => needs_review


Comment:

 Finally got around to reinstalling sage after a hard-drive failure. Hoping
 to get back on track with contributing to sage. Sorry for the incredibly
 slow response.

 Hopefully this should tie up this loose end.

 While I do agree that there is room for improving the speed of calculating
 binomial coefficients mod N, I don't feel like it's worth bloating the
 binomial function with multiple extra lines of code for something which
 doesn't seem to be used much.

 Perhaps it could be added as a feature at a later stage when the need is
 there.

 However, I feel that this patch adequately addresses the original issue:
 that elements are treated as integers and returned as such, with no
 attempt to return them to their original class. This could potentially
 help with other cases.

 Thanks for the advice with regards to the other issues.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12179#comment:12>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to