#11763: Parents for polyhedra
------------------------------------------+---------------------------------
Reporter: vbraun | Owner: mhampton
Type: enhancement | Status: closed
Priority: major | Milestone: sage-5.6
Component: geometry | Resolution: fixed
Keywords: | Work issues:
Report Upstream: N/A | Reviewers: Dmitrii Pasechnik
Authors: Volker Braun | Merged in: sage-5.6.beta1
Dependencies: #11634, #13109, #11310 | Stopgaps:
------------------------------------------+---------------------------------
Comment (by novoselt):
Hey Volker,
Do you remember what was the reason for this change in `normalize_rays`?
{{{
#!diff
diff --git a/sage/geometry/cone.py b/sage/geometry/cone.py
Index: sage/geometry/cone.py
===================================================================
--- a/sage/geometry/cone.py
+++ b/sage/geometry/cone.py
@@ -568,7 +568,10 @@
V = lattice.base_extend(QQ)
for n, ray in enumerate(rays):
try:
- ray = V(ray)
+ if isinstance(ray, (list, tuple, V._element_class)):
+ ray = V(ray)
+ else:
+ ray = V(list(ray))
except TypeError:
raise TypeError("cannot convert %s to %s!" % (ray, V))
if ray.is_zero():
}}}
It seems that if `V` does not want to take a `ray`, we should not force
it.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11763#comment:58>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
