#5438: [with patch, needs work] Incorrect documentation and/or functionality in
plot filling
----------------------+-----------------------------------------------------
Reporter: kcrisman | Owner: kcrisman
Type: defect | Status: assigned
Priority: minor | Milestone: sage-3.4.2
Component: graphics | Keywords: plot fill
----------------------+-----------------------------------------------------
Comment(by wcauchois):
Replying to [comment:7 mabshoff]:
> This doctest failure needs to be addressed:
> {{{
> sage -t -long devel/sage/sage/plot/plot.py
> **********************************************************************
> File "/scratch/mabshoff/sage-3.4.1.alpha0/devel/sage-
main/sage/plot/plot.py", line 3037:
> sage: [len(generate_plot_points(f, (-pi, pi), adaptive_tolerance=i))
for i in [0.01, 0.001, 0.0001]]
> Expected:
> [42, 67, 104]
> Got:
> [36, 65, 91]
> **********************************************************************
> File "/scratch/mabshoff/sage-3.4.1.alpha0/devel/sage-
main/sage/plot/plot.py", line 3040:
> sage: [len(generate_plot_points(f, (-pi, pi), adaptive_recursion=i))
for i in [5, 10, 15]]
> Expected:
> [34, 144, 897]
> Got:
> [33, 131, 900]
> **********************************************************************
> }}}
> It is also unclear to me if the changes here do not degrade the default
plot settings since the now the adaptive plotting seems to generate fewer
points.
>
> Bill: Do not give positive reviews to any patch that causes doctest
failures.
>
> Cheers,
>
> Michael
For some reason, I thought the bug in question was evident in the main
branch as well, meaning it would have had nothing to do with this patch. I
see now that this is not the case; I must have got branches confused.
Thanks for catching my mistake :).
kcrisman: Might this bug have something to do with line 3037?
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5438#comment:8>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
