#4667: [with patch, needs work] quadratic twists for p-adic L-functions
---------------------------+------------------------------------------------
Reporter: wuthrich | Owner: was
Type: enhancement | Status: new
Priority: minor | Milestone: sage-3.4.2
Component: number theory | Keywords: padic l-functions, quadratic twists
---------------------------+------------------------------------------------
Changes (by GeorgSWeber):
* milestone: sage-3.4.1 => sage-3.4.2
Comment:
Uh oh.
No offense meant, I was just too excited so I started the review after
midnight.
And sorry, my fault, I re-checked my setup and it seems that somehow I had
forgotten a "sage -b" in the course. I do see the failures against vanilla
sage-3.4, and they seem to be severe:
{{{
File "/Users/georgweber/Public/sage/sage-3.4/local/lib/python/site-
packages/sage/schemes/elliptic_curves/ell_rational_field.py", line 5164:
sage: [P[0] for P in
EllipticCurve([0,0,0,-468,2592]).integral_points()]
Expected:
[-24, -18, -14, -6, -3, 4, 6, 18, 21, 24, 36, 46, 102, 168, 186, 381,
1476, 2034, 67246]
Got:
[-24, -18, -14, -6, -3, 4, 6, 18, 21, 24, 36, 46, 102, 186]
}}}
and most of the other failed doctests also point to missing integral
points. There had been a patch of John (IIRC) that had healed an issue
with this, and the current patch of Chris seems to miss these parts (more
precisely seems to revert the code to the old buggy state).
As a by-result, this means that I definitely shouldn't try to review
patches without being well-rested. Which probably means I won't be able to
do reviews at all. :-(((
Cheers,
gsw
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4667#comment:14>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
