#13928: Problematic file filter in skip() from sage-ptest
---------------------------------+------------------------------------------
Reporter: ncohen | Owner: mvngu
Type: defect | Status: needs_review
Priority: major | Milestone: sage-5.6
Component: doctest | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers:
Authors: Nathann Cohen | Merged in:
Dependencies: | Stopgaps:
---------------------------------+------------------------------------------
Comment (by jhpalmieri):
Maybe the test shouldn't filter the absolute path, but the path relative
to `SAGE_ROOT`. I don't see why we should skip directories starting with
`.` if they are not in the Sage library (if I want to test some random
collection of files in one of my own directories, why can't the directory
start with a `.`?). So
{{{
#!python
G = os.path.realpath(G)
if G.startswith(SAGE_ROOT):
if os.path.sep + '.' in G[len(SAGE_ROOT):].lstrip(os.path.sep + '.'):
return True
# perhaps also put this here:
if G.find(os.path.join('doc', 'output')) != -1:
return True
}}}
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13928#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
