#13928: Problematic file filter in skip() from sage-ptest
---------------------------------+------------------------------------------
Reporter: ncohen | Owner: mvngu
Type: defect | Status: needs_review
Priority: major | Milestone: sage-5.6
Component: doctest | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers:
Authors: Nathann Cohen | Merged in:
Dependencies: | Stopgaps:
---------------------------------+------------------------------------------
Comment (by leif):
Replying to [comment:14 nbruin]:
> Anyway, your current patch is fragile and not an improvement (other than
that it apparently fixes your particular problem). Any time you require a
`realpath` you're probably doing something wrong. It's a very expensive
operation and it's fragile. You should really work with file paths as
presented to you. The user probably had a reason for presenting the path
to you in the way he/she did. Don't second-guess him/her. In fact, with
remounting and loop mounting, files might not ''have'' a canonical
`realpath` anyway, showing that relying on it is a logical flaw.
Thanks. I was always against resolving all symbolic links in `SAGE_ROOT`,
but Jeroen decided to do so, unfortunately. This is a real mess with
filesystems that get mounted on different directories (for example
depending on the machine or the operating system you currently booted),
and by the way -- at least in my case -- always blows up the log files
[and screen output] because the "real path" is three to ten times longer
than the specified one, i.e., the one with symlinks.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13928#comment:16>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
