#13949: Make mutability on matrices a simple bint flag
----------------------------------+-----------------------------------------
Reporter: nbruin | Owner: jason, was
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.6
Component: linear algebra | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers:
Authors: Nils Bruin | Merged in:
Dependencies: | Stopgaps:
----------------------------------+-----------------------------------------
Comment (by nbruin):
OK, I think the patches presently supplied are safe for merger. Main work:
- mutability is stored on `Matrix` via a direct `bint` flag. This is much
more robust, because by default it gets initialized to a valid (`False`)
value. The attribute is `_immutability`, so matrices are by default
mutable, as before.
- `matrix_integer_dense` previously called `Matrix.__init__`. That call
has been unpacked. Previously, this code set `_nrows` and `_ncols` twice!
- added doc to `Matrix.__init__` to make explicit the contract
- the approach in `matrix_integer_2x2` is now as documented (before it
seemed dodgy)
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13949#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
