#13954: New Gap spkg (>=4.5) does not build with shared only GMP/MPIR
-----------------------------------+----------------------------------------
       Reporter:  jpflori          |         Owner:  tbd     
           Type:  defect           |        Status:  new     
       Priority:  major            |     Milestone:  sage-5.7
      Component:  packages         |    Resolution:          
       Keywords:  spkg gap cygwin  |   Work issues:          
Report Upstream:  N/A              |     Reviewers:          
        Authors:                   |     Merged in:          
   Dependencies:                   |      Stopgaps:          
-----------------------------------+----------------------------------------

Comment (by kcrisman):

 {{{
 #!diff
 diff --git a/spkg-install b/spkg-install
 --- a/spkg-install
 +++ b/spkg-install
 @@ -86,34 +86,6 @@
      exit 1
  fi

 -# On Cygwin installations the GAP build creates a file 'gap.exe',
 -# and then tries to strip the file 'gap'.
 -# This broke the build on old Cygwin installations.
 -# On newer Cygwins, 'gap' is automatically "translated" to 'gap.exe'.
 -if [[ "$UNAME" = CYGWIN ]]; then
 -    echo "Creating a dummy 'gap.exe' in 'bin/i686-pc-cygwin-gcc'..."
 -    cd "$SPKG_ROOT/src"
 -    mkdir -p bin/i686-pc-cygwin-gcc &&
 -    cd bin/i686-pc-cygwin-gcc &&
 -    touch gap.exe
 -    if [[ $? -ne 0 ]]; then
 -        # Something really went wrong.
 -        echo >&2 "Error creating a dummy gap.exe file."
 -        exit 1
 -    fi
 -    # Check if 'gap' is automatically "translated" to 'gap.exe'.
 -    # If not, create a symbolic link from 'gap' to 'gap.exe'.
 -    if [[ ! -f gap ]]; then
 -        echo "Creating a symbolic link from 'gap' to 'gap.exe'..."
 -        ln -s gap.exe gap
 -        if [[ $? -ne 0 ]]; then
 -            # Something really went wrong.
 -            echo >&2 "Error creating the symbolic link."
 -            exit 1
 -        fi
 -    fi
 -fi
 -
  echo "Building GAP..."
  cd "$SPKG_ROOT/src"
  $MAKE -j1
 @@ -144,11 +116,7 @@
  echo "Copying GAP startup script..."
  rm -f "$SAGE_LOCAL/bin/gap"
  cd "$SPKG_ROOT"
 -if [[ "$UNAME" = CYGWIN ]]; then
 -    cp patches/gap_cygwin "$SAGE_LOCAL/bin/gap"
 -else
 -    cp src/bin/gap.sh "$SAGE_LOCAL/bin/gap"
 -fi
 +cp src/bin/gap.sh "$SAGE_LOCAL/bin/gap"
  if [[ $? -ne 0 ]]; then
      echo >&2 "Error copying customized GAP startup script."
      exit 1
 }}}
 Yeah, if it works, then we are set.  It just finished building for me...
 `sage -b` now... that worked... Trying to start, `sage-location` is being
 run... it works!!!

 Commit and make the spkg, this is ready to go.

 > Not sure what you mean by needing to start GAP for Sage. Sage startup
 doesn't start a GAP session. The GAP workspace cache needs to be rebuilt
 once, though.

 Well, there is a GAP command that is run (and fails here, `gap -r -b -p -T
 -o 251m .../gap/sage.g`), so that sounds like GAP to me.  Also, upon a
 first start (or relocation), Sage always says something about stopping a
 GAP session.  But if it's not technically a session, that's fine; my point
 was that it does ''something'', which e.g. Singular and Maxima don't.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13954#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to