#13899: Don't use TAB characters for indentation
----------------------------------+-----------------------------------------
Reporter: jdemeyer | Owner: jason
Type: defect | Status: closed
Priority: trivial | Milestone: sage-5.6
Component: misc | Resolution: fixed
Keywords: | Work issues:
Report Upstream: N/A | Reviewers: Leif Leonhardy, Karl-Dieter
Crisman
Authors: Jeroen Demeyer | Merged in: sage-5.6.beta3
Dependencies: | Stopgaps:
----------------------------------+-----------------------------------------
Comment (by leif):
Replying to [comment:30 jason]:
> Large rebasing of tickets like #12719 could easily introduce subtle code
errors, and not forcing those changes should take priority over end-of-
line spacing.
Just checked, and as far as I can see, the only offending patch here was
removing an empty line from a file that #12719 removes in its entirety.
So I wouldn't say we broke much here, at least until now...
In general, patches IMHO shouldn't touch parts they don't have to (i.e.,
only doing some reformatting there), which we agreed on IIRC. But in this
case, the ''purpose of the ticket'' is to remove tabs (and "normalize"
code -- once and for all -- hopefully), so it does ''not'' touch code it
doesn't have to...
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13899#comment:32>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
