#13963: Fix checking for and resetting GAP workspaces
----------------------------------+-----------------------------------------
Reporter: jdemeyer | Owner: GeorgSWeber
Type: defect | Status: positive_review
Priority: critical | Milestone: sage-5.7
Component: build | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers: Volker Braun
Authors: Jeroen Demeyer | Merged in:
Dependencies: | Stopgaps:
----------------------------------+-----------------------------------------
Comment (by leif):
Replying to [comment:22 jdemeyer]:
> Replying to [comment:21 leif]:
> > I'd still let `-O0` override a user's O-level (in `$CFLAGS`) if
`SAGE_DEBUG=yes`, like most -- if not all -- other spkgs do.
> I don't think Sage should ever override user-chosen flags, so we should
always do
> {{{
> CFLAGS="-sage -specific -flags $CFLAGS"
> }}}
Well, IMHO depends. If `-foo` is mandatory to not break the build, it
should be ''ap''pended; same for options to `configure`. (`-L` is even
more troublesome, and `-I-` for example isn't portable.)
Unfortunately there's not always an option to toggle or invalidate a
previously (i.e., "user-specified") option, and flags may even conflict.
(The same is true for the opposite case, when a user wants to override
some option added by Sage or an spkg's build system. This especially
holds for `-g`, which we almost always add by default -- thereby probably
already overriding a user's choice; stripping afterwards may be
inappropriate in some cases.)
If a user sets `SAGE_DEBUG=yes`, he will or should be aware of the
consequences, which are documented (I think), and usually subject of a
corresponding warning message. If someone really wants to do debugging
without e.g. `-O0`, he'll certainly be able to modify `spkg-install` for
that purpose, which is trivial. Temporarily modifying `C*FLAGS` is more
tedious, and less experienced users may have (more or less intentionally)
some of them set, while still expecting `SAGE_DEBUG` to work as
advertised, without having to mess with other environment variables.
Ideally, we'd have some `SAGE_DEBUG_LEVEL`, or we'd at least separate
"standard" compiler options ''probably'' useful for debugging (such as
`-O0`) from usually package-specific ones, like `-DDEBUG_FOO`;
`configure` may also take special debug options specific to the package
(which IMHO is the main reason we do have `SAGE_DEBUG`).
Until we have `SAGE_DEBUG_CFLAGS`, say, which could easily be set/modified
by the user, I'd still (try to) override e.g. `-O2` by default (if
`SAGE_DEBUG=yes` of course).
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13963#comment:26>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
