#13929: Wrong comparison of sparse vectors
---------------------------------------------------+------------------------
Reporter: tfeulner | Owner: jason, was
Type: defect | Status:
positive_review
Priority: major | Milestone: sage-5.7
Component: linear algebra | Resolution:
Keywords: comparison, sparse, free module | Work issues:
Report Upstream: N/A | Reviewers: Christian
Nassau
Authors: Thomas Feulner | Merged in:
Dependencies: | Stopgaps:
---------------------------------------------------+------------------------
Changes (by cnassau):
* status: needs_review => positive_review
* reviewer: => Christian Nassau
Comment:
The patch seems to be correct (tested it against Sage 5.5) and does indeed
fix a bug in the sorting order. I would have chosen a more informative
doctest, for example
{{{#!python
sage: sorted(FreeModule(GF(3),2,sparse=True))
[(0, 0), (0, 1), (0, 2), (1, 0), (1, 1), (1, 2), (2, 0), (2, 1), (2, 2)]
sage: sorted(FreeModule(GF(3),2,sparse=False))
[(0, 0), (0, 1), (0, 2), (1, 0), (1, 1), (1, 2), (2, 0), (2, 1), (2, 2)]
}}}
But I think the patch is ready to go as it is, so I'm giving it a positive
review.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13929#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
